Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with translation on Brave #90

Open
dantecarlo opened this issue Jan 9, 2024 · 7 comments
Open

Bug with translation on Brave #90

dantecarlo opened this issue Jan 9, 2024 · 7 comments

Comments

@dantecarlo
Copy link

When I access the web with the Brave browser, it does not detect the language correctly and does not enter the fallback correctly.
I will download the code and try to recreate the error.
I can also contribute to the Spanish translation.

error

@hellomuthu23
Copy link
Owner

When I access the web with the Brave browser, it does not detect the language correctly and does not enter the fallback correctly. I will download the code and try to recreate the error. I can also contribute to the Spanish translation.

error

I cannot reproduce it on latest brave version 120.0.6099.199. Are you using the same version? and windows os?

@dantecarlo
Copy link
Author

I am using v 1.61.114 of Brave on a Windows 11 OS

@vnscosta
Copy link
Contributor

Hey @dantecarlo, I can't reproduce it too, I'm using the latest brave version Version 1.61.114 Chromium: 120.0.6099.199 (Official Build) (x86_64) on Sonoma 14.2.1. Can you please see if it's there some errors on inspect console or try in the anonymous window without any extensions?

@dantecarlo
Copy link
Author

I got the error again. I opened an incognito tab and it happened again.

@dantecarlo
Copy link
Author

image

@SlyRaider
Copy link

SlyRaider commented Mar 4, 2024

Hello,

I get the same bug on Firefox. But the browser doesn't matter, same thing on Chrome.

Actually, I think the problem is that i18n retrieves the browser language by default, but only 3 languages are available in the app: en-US, pt-BR and zh-Hant. My browers are in fr or fr-FR. In my local storage variables, i18n retains this values:

image

And so the language selection is empty:

image

If the language retrieved by the browser is not available, you should select en-US by default I guess?

@lotmek
Copy link
Contributor

lotmek commented Jul 11, 2024

Hello, I ran through the same issue. Here is a PR to fix it: #101 thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants