-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DFP [7.x-2.x] Maintainer #1
Comments
Yes @scottalan I saw that but have no idea who that is so I opened this https://www.drupal.org/project/prebidjs/issues/2934453. Feel free to fork and send me PRs or take full control 👍 |
@heshanlk Thanks for responding. I'll see if I can't get some help moving that issue along. |
That'd be great!. Let me know if I can help you with anything. |
@heshanlk, from what I can gather I'm seeing that there is a legacy version and I'm assuming this is anything < 1.x.x? It looks like even prebid.org is behind unless it is actually using the "latest" and they just haven't updated the option. I wasn't sure what the versioning requirements were for the Maybe Let me know what you think. |
@scottalan the idea of using Libraries API was to remove that kind of version dependencies, don't you think using just the version you want in sites/all/libraries would do it?. I can't remember how much the syntax is different for those two versions so feel free to brank off if that makes sense. |
I ended just adding a submodule (prebid) to the 7.x-2.x branch of DFP. The fact that there is no standardization to the bidder parameters is insane IMO. I opted to go with a plugin system via ctools that allows a module to create individual For example: One of the bidders we are using is
I had to define a different Here's the patch we are testing now https://www.drupal.org/project/dfp/issues/2980845#comment-12730946 |
I just came across your module and I'd like to help out. I maintain the 7.x-2.x branch of the DFP module. I noticed someone (maybe someone you know) grabbed the same namespace. Is this where you are keeping development of this module or do you have a project page on D.O. as well?
I like the idea of using ctools exports to store data about each of the bidders. I will probably have to update a few things to get it to work for our client so I might be creating a few PRs. I had to do something similar for DFP which is why there is a 2.x branch.
The text was updated successfully, but these errors were encountered: