Skip to content
This repository has been archived by the owner on Oct 30, 2019. It is now read-only.

BigEndian vs LittleEndian #3

Open
MinusPL opened this issue Oct 18, 2019 · 1 comment
Open

BigEndian vs LittleEndian #3

MinusPL opened this issue Oct 18, 2019 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@MinusPL
Copy link

MinusPL commented Oct 18, 2019

Each packet in PacketType has wrong hex value.
Every packet is sent in Little Endian bytes. That means that most significant byte is actually on the right, not left.
Due to this every packet has wrong numerical value assigned. For example:
Packet ClientEnterServerReq is actually assigned to value 0x1302 rather than 0x0213. 0x0213 is shown in any raw binary dump of data.

Didn't notice if you meant to have them in Little Endian byte order, but it can cause some problems.

@holly-hacker
Copy link
Owner

Seems like it's an update to the protocol then, this worked fine in the past. I'm not really interested in maintaining this so feel free to make a fork.

@holly-hacker holly-hacker added bug Something isn't working good first issue Good for newcomers labels Oct 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants