Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Chi-square distribution #10

Open
hot9cups opened this issue Oct 27, 2020 · 9 comments
Open

Add support for Chi-square distribution #10

hot9cups opened this issue Oct 27, 2020 · 9 comments
Assignees
Labels

Comments

@hot9cups
Copy link
Owner

Go through the Gaussian distribution class, the Binomial class and the Exponential class which are subclasses of General distribution class.

I would like to expand this to include a fourth distribution, the Chi-square Probability Distribution.
It should be able to calculate mean, standard deviation, and create basic plots like those in the classes I linked.

@rachitmanas
Copy link

I would like to try working on this issue. Please assign it to me.

@hot9cups
Copy link
Owner Author

@rachitmanas sure thing :)
Before you go ahead, would you mind commenting about the approach you're going to take ?

@rachitmanas
Copy link

@hot9cups Basically I will just copy the same format as of other distributions made. I will change the parameters and formula and some function definition according to the Chi Square distribution.

@rachitmanas
Copy link

Can I use scipy or mpmath for incomplete gamma function calculation?

@hot9cups
Copy link
Owner Author

@rachitmanas sounds good.
About the scipy function, we'll have a look at that once you draft the PR
I'd ideally like to keep the dependencies to a minimal, but if there's no other way it's fine :)

@hot9cups
Copy link
Owner Author

@rachitmanas Hope you're doing well. How are you progressing with the issue? :)

@hot9cups
Copy link
Owner Author

I'm assuming @rachitmanas isn't working on this anymore, this issue is still open.

@m0hit-kumar
Copy link

I would like to work on it

@hot9cups
Copy link
Owner Author

@m0hit-kumar assigned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants