Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Poisson distribution #54

Open
hot9cups opened this issue Nov 1, 2020 · 12 comments
Open

Add support for Poisson distribution #54

hot9cups opened this issue Nov 1, 2020 · 12 comments
Assignees
Labels

Comments

@hot9cups
Copy link
Owner

hot9cups commented Nov 1, 2020

Go through the Gaussian distribution class, the Binomial class and the Exponential class which are subclasses of General distribution class.

I would like to expand this to include another distribution, the Poisson Probability Distribution.
It should be able to calculate mean, standard deviation, and create basic plots like those in the classes I linked.

@AmeyaPhadnis-2019H1030012G

Please assign this issue to me, I am new to open source and would like to contribute

@hot9cups
Copy link
Owner Author

hot9cups commented Nov 1, 2020

@AmeyaPhadnis-2019H1030012G I'd be glad to assign it to you! Before that, could you tell me a bit about how you plan to approach it ?

@ghost
Copy link

ghost commented Nov 2, 2020

Hi @hot9cups. If this does not get assigned, I would like to complete this task. To prepare, my plan is to go through the code for the distribution classes, their respective tests in test.py, documentation for matplotlib, read up on poisson distribution, come up with a numbers_poisson.txt for demo data. For the implementation, I'm going to mimic the implementation of the other distribution classes

@hot9cups
Copy link
Owner Author

hot9cups commented Nov 2, 2020

@ho-jonathan Since AmeyaPhadnis seems to have deserted us(And they also have request for claims on two other issues so if they come back there's always that), I'm assigning it to you.

That plan sounds perfect! Please go ahead!

@hot9cups hot9cups assigned ghost Nov 2, 2020
@hot9cups
Copy link
Owner Author

@ho-jonathan I was wondering how you're progressing with the PR

@hot9cups
Copy link
Owner Author

@ho-jonathan are you still interested in working on this? I will assume it's a no if you're unable to respond within a week :(

@hot9cups hot9cups unassigned ghost Dec 7, 2020
@saeyma
Copy link

saeyma commented Oct 8, 2021

Hi @hot9cups, I would like to work on this. Can you please assign this to me?

@hot9cups
Copy link
Owner Author

hot9cups commented Oct 8, 2021

@saeyma Done :)

@whynesspower
Copy link

Hi @hot9cups If this does not get assigned, I would like to work on this task too. I can assure you, I can provide you with a errorless PR in a matter of 5 hours. Thankyou =)

@hot9cups
Copy link
Owner Author

@whynesspower Thanks for being interested :)
Well saeyma is already working on it so I'm sorry, it's already been assigned.

@saeyma
Copy link

saeyma commented Oct 17, 2021

Hey @hot9cups, can you tell me how to trigger github actions manually? Right now, it happens once a day (I think) but it's slowing down development. I want to run Python Lint Test.

@hot9cups
Copy link
Owner Author

@saeyma The github actions are just flake8 linting tests plus the unit tests in tests.py.
Ideally, you should be running the tests.py file before making a commit so you can check that the code you added actually works(assuming you added tests for the distribution you're working on) as well as haven't broken any other distributions.
As for the linting tests, you can install flake8 on your computer and could check for linting errors via command line and/or various other editors.

Also, the github actions are supposed to run automatically, but there's a restriction in place for first time contributors.
First time contributors to this repo always need my permission to get the action triggered.
You shouldn't require the permission from your second PR onwards :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants