Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for PDF plots #71

Open
saeyma opened this issue Oct 26, 2021 · 1 comment
Open

Add tests for PDF plots #71

saeyma opened this issue Oct 26, 2021 · 1 comment

Comments

@saeyma
Copy link

saeyma commented Oct 26, 2021

The tests in test.py contains code to verify the numerical correctness of the respective classes. However, there is a PDF plot function that plots a graph using matplotlib (soon seaborn) which is not tested.

Your input as a contributor:

  1. Figure out a way to verify the plot. (Random suggestion: Store a image file and compare generated plot with it) Looking for more robust ideas and open to discussions.
  2. Implement solution discussed in 1 and add tests to respective classes.
@hot9cups
Copy link
Owner

When I was initially writing tests, I did want to have tests for plotting functions, but I couldn't think of a solution or find much online. I'm not sure if any other similar library has tests for plotting functions(open sourced code atleast).

If you do have more ideas or are interested in implementing idea #1, I can assign it to you.
(Not sure how you'd compare the two plot images though, seems quite computationally expensive doesn't it?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants