Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More standard ggplot2 behavior #3

Open
antaldaniel opened this issue Jul 21, 2019 · 0 comments
Open

More standard ggplot2 behavior #3

antaldaniel opened this issue Jul 21, 2019 · 0 comments

Comments

@antaldaniel
Copy link

Excellent work, I have been thinking for some time to do the same. I think that this is very good groundwork for a widely used geometry, but I find it a bit too specific. I have two issues.

a) I think that any not necessary adjustment, including theming, coloring, coord_flip() atc should be left exactly like in the case of geom_boxplot () to the user.

For demo purposes I think that the Economist theme is great, because that is what everybody knows and envies, but people will use the geom widely if it fits smoothly into their existing reports, documents, charts. Flipping the coords is important for demonstrating the Economist origin, but it is a standard function and can be confusing because it changes the x, y values.

b) for me a more logical usage would be

ggplot ( data = dat,
aes ( x = numeric_var, minpoint = ( quantile (numeric_var, .1, na.rm=TRUE), midpoint = ( median(numeric_var, na.rm=TRUE), maxpoint = ( quantile (numeric_var, .9, na.rm= TRUE), group = metro_area)) +
geom_econdist( aes ( mincolor = 'lightblue', midcolor = 'grey10', maxcolor = 'blue') +
coord_flip() +
labs () +
theme ()

It would be a more flexible version of the geom_boxplot (), where the quantile values cannot be moved, and the midpoint can take mean, average, or some weighted average value. This would allow both already computed tables to be used, as in your example ,or a geom_boxplot() like charting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant