Bug in SimpleWorld.commit() ?

[DavePearce]

Description

Currently, SimpleWorld.commit() is defined as follows:

@Override
  public void commit() {
    accounts.forEach(
        (address, account) -> {
          if (!account.updateParent()) {
            parent.accounts.put(address, account);
          }
        });
  }

However, this seems to be in conflict with this:

  @Override
  public Collection<Address> getDeletedAccountAddresses() {
    return accounts.entrySet().stream()
        .filter(e -> e.getValue() == null)
        .map(Map.Entry::getKey)
        .toList();
  }

It seems to me that we want account == null || !account.updateParent() as the criteria in commit() above.

Thoughts?

[lu-pinto]

Yup that needs a null check as deleteAccount puts in nulls in the collection and commit may be called after deleteAccount: AbstractMessageProcessor.java#L115-L116 . So definitely the collection is not null free