You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As title, it will be nice to be able to use ROI to select the fitting range of a EELS model. Something like what GMS can do for background subtraction. Would it possible to do it with SpanROI that we have currently?
Additional information
This is on the '2.0.dev0' version. It seems like ROI doesn't work with model1D object right now.
s = hs.datasets.two_gaussians()
m = s.create_model()
roi = hs.roi.SpanROI()
m.plot()
sliced_signal = roi.interactive(m, axes=m.axes_manager.signal_axes)
The text was updated successfully, but these errors were encountered:
You can set the fitting range interactively using set_signal_range. If you don't pass the signal range as an argument, it automatically displays a ROI to select the signal range for fitting. Does it meet you needs?
That said, this feature predates HyperSpy ROIs, and, therefore, it is not implemented using ROIs. I think that it would be good to reimplement the feature using ROIs instead. The same goes for all other functionality using interactive_range_selector. However, this is a discussion to have in the hyperspy repository.
Also, the fact that using ROIs on a Model raises an obscure exception is a bug: it should either work (not currently implemented) or raise an informative NotImplemented exception. Again, this is HyperSpy issue.
@HanHsuanWu, would you like to open those issues in the HyperSpy repository?
Describe the functionality you would like to see.
As title, it will be nice to be able to use ROI to select the fitting range of a EELS model. Something like what GMS can do for background subtraction. Would it possible to do it with SpanROI that we have currently?
![image](https://private-user-images.githubusercontent.com/112028355/295130033-4c0dfa0b-3a5c-494c-a7ed-11af6cf5319f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ5NzUwMzgsIm5iZiI6MTcyNDk3NDczOCwicGF0aCI6Ii8xMTIwMjgzNTUvMjk1MTMwMDMzLTRjMGRmYTBiLTNhNWMtNDk0Yy1hN2VkLTExYWY2Y2Y1MzE5Zi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwODI5JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDgyOVQyMzM4NThaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT03NWJjN2U0YmZiNDI1MDE3NDlhZmM0NGEyNDg0NGRkOTgwNzczMDYxMTU1NjY2NzY4ZDJkNzExMzA0NWFmNTIwJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.VQZyYF41GXZ_HRK_eXc9woLMftHkqtgVs41jGPrnUrw)
Additional information
This is on the '2.0.dev0' version. It seems like ROI doesn't work with model1D object right now.
The text was updated successfully, but these errors were encountered: