Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C# 7.1: Async Main #1023

Closed
siegfriedpammer opened this issue Jan 11, 2018 · 2 comments
Closed

C# 7.1: Async Main #1023

siegfriedpammer opened this issue Jan 11, 2018 · 2 comments
Labels
C# Decompiler The decompiler engine itself Help Wanted New Feature
Milestone
3.1

Comments

@siegfriedpammer
Copy link
Member

Specification: https://github.com/dotnet/csharplang/blob/master/proposals/csharp-7.1/async-main.md
Difficulty: Easy
Time needed: 2-3 hrs

  1. Add unit tests: In this case only pretty tests make sense.
  2. Extend the code in CSharpDecompiler.MemberIsHidden to hide the generated <Main> method in the decompiled code, if settings.AsyncAwait is set.
@siegfriedpammer siegfriedpammer added this to the 3.1 milestone Jan 11, 2018
@dgrunwald dgrunwald mentioned this issue Jan 11, 2018
Open
@MikeFH
Copy link
Contributor

MikeFH commented Jan 13, 2018

Is it OK if I take a look at this ?

@siegfriedpammer
Copy link
Member Author

Yes, you are very welcome to submit a pull request for this feature. Please base your pull request on the master branch and follow the guidelines for unit tests.

If you have any questions, feel free to ask!
Thank you for your interest in contributing to this project!

@MikeFH MikeFH mentioned this issue Jan 15, 2018
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
C# Decompiler The decompiler engine itself Help Wanted New Feature
Projects
None yet
Milestone
3.1
Development

No branches or pull requests
2 participants
@siegfriedpammer @MikeFH