-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow HTML in title_resolved (to allow font-awesome icons) #305
Comments
@idlesign The The suggested method with annotating templates with I also taught about third option - sanitize the HTML with html-sanitizer or something similar. It is easiest to use, but would introduce additional dependency. |
Yeap, it's single entry point (code edit) versus multiple (override
Blocks are fine, except we'll need to define them carefully to cover top user cases.
That'll cost us not only a dependency but also a performance hit. |
OK, so do you agree that the best method would be to use The templates annotation can be left to different issue - I think, it we can find some logical parts and that the blocks can be nested (users can choose which level they will override). |
What I'm concerned with is: if it'd be a global settings marking all For many years So if we're able to come up with a solution covering a common case, it'd be fine. But if it's a one or two projects need it won't worth additional complexity. |
There is 1 thing, for which I have to override the whole template. I am using font-awesome icons, so I need to make the
item.title_resolved
safe (see #91 (comment)). I don't think, that is wise to add something like that to templates generally (in some systems users could have access to the sitetree editing). But I can either do something likeso that only this part of the template needs to be overriden, or it can be done by some settings (like
SITETREE_FORCE_SAFE=True
).What do you think is better?
This has been already discussed at #304 and #91 (comment)
The text was updated successfully, but these errors were encountered: