Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean apollon.tools.standardize #1

Open
Teagum opened this issue Mar 25, 2021 · 0 comments
Open

Clean apollon.tools.standardize #1

Teagum opened this issue Mar 25, 2021 · 0 comments
Assignees
@Teagum
Labels
documentation Improvements or additions to documentation invalid This doesn't seem right

Comments

@Teagum
Copy link
Member

Teagum commented Mar 25, 2021 •
edited
Loading

Thetools.standardize function computes the z-transform, or z-score of the input array. The name standardize is, hence, misleading. I should rather call it 'z_score', or 'standard_score'.

Todo

  • rename the function
  • Improve the doc string the give more information on what is a z score.
  • find all calls to it and update them
  • Write unit tests
@Teagum Teagum self-assigned this Mar 25, 2021
@Teagum Teagum added documentation Improvements or additions to documentation invalid This doesn't seem right labels Mar 25, 2021
@Teagum Teagum changed the title Clean tool.standardize Clean apollon.tool.standardize Mar 25, 2021
@Teagum Teagum changed the title Clean apollon.tool.standardize Clean apollon.tools.standardize Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Teagum Teagum

Labels
documentation Improvements or additions to documentation invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Teagum