Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameter to make_dataset.py for running with parameterized pref_name count #24

Open
jonlandrum opened this issue Sep 1, 2020 · 1 comment
Labels
data Related to the data processing code enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@jonlandrum
Copy link
Contributor

Synopsis
The program requires a computer with very generous resources available. If those resources are not available, the program will crash with an error stating such.

Acceptance Criteria

  • Add arguments to the file make_dataset.py to accept a pref_name count value, and set the value to 100 by default
  • Use this parameter on line 66 instead of hard-coding the expression count > 100
@jonlandrum jonlandrum changed the title Add parameter to make_dataset.py for running with parameterized pref_name count Add parameter to make_dataset.py for running with parameterized pref_name count Sep 1, 2020
@ikmckenz ikmckenz added data Related to the data processing code enhancement New feature or request good first issue Good for newcomers labels Sep 2, 2020
@ikmckenz
Copy link
Owner

ikmckenz commented Sep 2, 2020

Should use argparse to set the value, look at how --trees is set in src/models/train_structuretomoa.py for guidance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data Related to the data processing code enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants