Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted plugins in the addons folder are still considered installed #15

Open
univeous opened this issue May 31, 2023 · 5 comments
Open

Comments

@univeous
Copy link
Contributor

After a plugin is installed through this script, delete the plugin's whole folder in addons/,
the plugin will still be considered as installed.
when running install or update, nothing will happen.
I think they should be re-installed.

@imjp94
Copy link
Owner

imjp94 commented Jun 1, 2023

Yes, because currently gd-plug doesn't verify installed files when executing any commands.
But it is totally doable, as all the files installed have been listed in ./plugged/index.cfg under dest_files

Current workaround would be execute uninstall then install again

The solutions I can think of:

  • Add a simple check to see if the addons/{plugin} directory exist(doesn't verify the files within), reinstall if not
  • Add new verify command to check if all files are properly installed

@univeous
Copy link
Contributor Author

univeous commented Jun 4, 2023

the current workaround is kind of confusing, I think your solution looks good

@russmatney
Copy link

Just ran into this today! I think it'd make sense for this verify check to run when install and/or status are called.

uninstall would remove everything, wouldn't it? I suppose it'll all get recloned again...

Slightly related, but it seems like it'd be useful to specify which addon to apply a task to - trying to get one addon fixed up can run into issues/lots of noise when another addon happens to be updated. Tho i suppose i should be pinning my addon versions.

@imjp94
Copy link
Owner

imjp94 commented Mar 24, 2024

@russmatney
One of the main reason that I wished to make verify a command on its own, was because it can be a really slow process to verify every single files.

For a cleaner workaround at the moment, you can try

  1. Comment out the plugin in plug.gd
  2. Then execute install command to remove the "unplugged" plugin
  3. Uncomment the plugin in plug.gd
  4. Execute install command again
    This will re-install the specific plugin alone.

Yeah, I agree, it can be really useful to handle specific addon(add, remove, update, etc.) one at a time.
I am still figuring how to achieve that, because gd-plug is designed to manage plugins based on the configuration script just like vim-plug or npm.

@russmatney
Copy link

Gotcha, thanks for the workaround. I eventually realized my confusion was because I hadn't specified the 'included' option, and one of my plugins was installing an earlier version of another - twas very confusing for a bit, haha

gd-plug has been great to use so far - i'm very happy to have a quicker way to manage godot addons, thanks for creating and sharing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants