Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated property: 'process' #16

Open
DarkChris86 opened this issue Apr 2, 2020 · 12 comments
Open

Deprecated property: 'process' #16

DarkChris86 opened this issue Apr 2, 2020 · 12 comments

Comments

@DarkChris86
Copy link
Contributor

DarkChris86 commented Apr 2, 2020

Hey @imranhsayed!

I got the following message in frontity app:
image

Bests,
Chris

@luisherranz
Copy link
Collaborator

luisherranz commented Apr 3, 2020

Hey @DarkChris86, thanks for the PRs 🙂

If you look at the docs, the signature of the functions also changed. Now they receive objects, like this:

const processor = {
  test: ({ node }) => { /* ... */ },
  processor: ({ node }) => { /* ... */ },
};

The change is backward compatible but we will deprecate the old API at some point. Would you mind adding that change to your PRs? Thanks!!

@DarkChris86
Copy link
Contributor Author

Hey @luisherranz .

Yes, I'm going to modify them like this! Thank you for friendly note! ; )

@luisherranz
Copy link
Collaborator

Thanks to you @DarkChris86! 😄

@DarkChris86
Copy link
Contributor Author

It's done. Could you check them ( @luisherranz )?

Thanks,
Chris

@imranhsayed
Copy link
Owner

@DarkChris86
Approved and merged the PR.

@DarkChris86
Copy link
Contributor Author

@imranhsayed
When it will be available via npm update?
https://www.npmjs.com/package/frontity-contact-form-7

Thanks,
Chris

@luisherranz
Copy link
Collaborator

luisherranz commented Apr 6, 2020

Thanks @DarkChris86! 🙌 🙂 (and @imranhsayed)

@davidrhoderick
Copy link

davidrhoderick commented Jun 28, 2020

I'm still getting this error on the latest version installed by NPM (0.1.4), plus the form isn't showing up on a page that renders the code to a page via a custom field using <Html2react />. Anything I can do to fix the error and will it fix the contact form?

EDIT: The form works, I just needed to use a WYSIWYG field instead of a text area as provided by ACF Pro.

@luisherranz
Copy link
Collaborator

@imranhsayed can you please release a new version in npm?

@davidrhoderick
Copy link

@imranhsayed any update on releasing a new version in npm? The contact form isn't even showing up on my site now.

It's funny, on my laptop, I don't get this error, so it might be related to the version of npm being used. I'll look into this a bit more...

@imranhsayed
Copy link
Owner

Released the new version on npm

@davidrhoderick
Copy link

Thanks @imranhsayed the latest version doesn't have this bug but I have found a new error with the latest version I will create another issue about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants