Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make memory ownership clear in code comments. #89

Closed
IAmNotHanni opened this issue Apr 19, 2020 · 3 comments
Closed

Make memory ownership clear in code comments. #89

IAmNotHanni opened this issue Apr 19, 2020 · 3 comments
Assignees
@IAmNotHanni
Labels
cat:enhancement enhancement/requested feature/update of existing features diff:beginner beginner skils required
Milestone
v0.1-alpha.3

Comments

@IAmNotHanni
Copy link
Member

IAmNotHanni commented Apr 19, 2020 •
edited
Loading

Answer the following questions in the comments for every method:
Does a function

  • alter memory ownership?
  • take exclusive ownership?
  • share ownership?
  • delete resources?
  • allocate resources?
  • construct resources?
  • alter the lifetime of a resource?
@IAmNotHanni IAmNotHanni added diff:beginner beginner skils required cat:enhancement enhancement/requested feature/update of existing features code quality labels Apr 19, 2020
@IAmNotHanni IAmNotHanni added this to the v0.2 alpha demo. milestone Apr 19, 2020
@IAmNotHanni IAmNotHanni self-assigned this Apr 19, 2020
@IAmNotHanni IAmNotHanni changed the title Make memory ownership clean in code comments. Make memory ownership clear in code comments. Apr 19, 2020
@IAmNotHanni
Copy link
Member Author

This is especially relevant for the entity-system! We should rethink if all those methods really need ownership of the resources passed to them.

@IAmNotHanni IAmNotHanni mentioned this issue Apr 19, 2020
Closed
@IAmNotHanni
Copy link
Member Author

Related: #81

@IAmNotHanni
Copy link
Member Author

I think we can close this by now.
This was resolved by RAII refactoring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IAmNotHanni IAmNotHanni

Labels
cat:enhancement enhancement/requested feature/update of existing features diff:beginner beginner skils required
Projects
None yet
Milestone
v0.1-alpha.3
Development

No branches or pull requests
2 participants
@IAmNotHanni @IceflowRE