Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust-peg dependency preventing v0.19.0 release #857

Closed
thanethomson opened this issue Apr 6, 2021 · 1 comment
Closed

rust-peg dependency preventing v0.19.0 release #857

thanethomson opened this issue Apr 6, 2021 · 1 comment
Assignees
Labels
bug Something isn't working rpc

Comments

@thanethomson
Copy link
Contributor

We can't release v0.19.0 of tendermint-rpc as it currently stands because of its dependency on unreleased changes in rust-peg. See

peg = { git = "https://github.com/kevinmehall/rust-peg.git", rev = "ba6019539b2cf80289190cbb9537c94113b6b7d1" }

I originally pinned the dependency to this commit due to the need for kevinmehall/rust-peg#245 to be released, but it's not clear when a new crate's going to be published.

As such, cargo publish fails for tendermint-rpc v0.19.0 at this point.

We have several options to solve this at present:

  1. Strip out the query parsing entirely. This will also mean we'd need to remove the Tendermint RPC CLI, or at least the part of it that depends on query parsing. This option is probably the easiest and quickest in the short term.
  2. Try to get rust-peg to work with its latest released version (v0.6.3 from July 2020). I'm least confident about this option.
  3. Replace rust-peg with a stable version of a different parser, e.g. nom or LALRPOP. I'm relatively confident I could replace the parser, but it's probably going to take some time to figure out how to use a new parsing library.

Delaying the release is unfortunately not an option.

What's the definition of "done" for this issue?

When we can complete the v0.19.0 release: #854

@thanethomson thanethomson added bug Something isn't working rpc labels Apr 6, 2021
@thanethomson thanethomson self-assigned this Apr 6, 2021
@thanethomson
Copy link
Contributor Author

Closed in #858

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working rpc
Projects
None yet
Development

No branches or pull requests

1 participant