Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add second hash step to DCE'd modules #13

Open
divmain opened this issue Mar 29, 2016 · 2 comments
Open

Add second hash step to DCE'd modules #13

divmain opened this issue Mar 29, 2016 · 2 comments
Labels

Comments

@divmain
Copy link
Member

divmain commented Mar 29, 2016

Since module hash is defined before all modules are loaded and processed, we'll need to either:

  • Perform a second hash step on modified bundles, so that the hash is a correct reflection of the runtime behavior; or
  • Modify the order of how interlock defines hashes. This would mean processing all modules and, after they have all been processed, hash and require-replace for all modules at once.
@divmain divmain added the next label Mar 29, 2016
@divmain
Copy link
Member Author

divmain commented Sep 13, 2016

A good compromise solution may be to process and hash all modules and then, after all modules have been processed, do the require-replace. This will allow us to modify the hashes if necessary before the replace occurs, but it shouldn't add any significant processing time, and the structure of compilation would be mostly unchanged.

recursive require-replace --> map over all completed modules at the end to do require-replace

@divmain
Copy link
Member Author

divmain commented Sep 15, 2016

To disambiguate, rename existing function to updateModuleDependencies and a new function called updateAllDependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant