Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipfs object patch add-link doesn't throw error for invalid ref argument #2473

Closed
RichardLitt opened this issue Mar 15, 2016 · 2 comments
Closed

ipfs object patch add-link doesn't throw error for invalid ref argument #2473

RichardLitt opened this issue Mar 15, 2016 · 2 comments
Labels
help wanted Seeking public contribution on this issue kind/support A question or request for support

Comments

@RichardLitt
Copy link
Member 

🐕  ipfs object patch QmUNLLsPACCz1vLxQVkXqqLX5R1X345qqfHbsf67hvA3Nn add-link foo
Error: Argument 'ref' is required

Use 'ipfs object patch add-link --help' for information about this command
🐕  ipfs object patch QmUNLLsPACCz1vLxQVkXqqLX5R1X345qqfHbsf67hvA3Nn add-link foo ''
QmSt5pTDuoZ5xi1iqroo8W57Fvp4U23h5gXfj6X7rWLcbn
🐕  ipfs object patch QmUNLLsPACCz1vLxQVkXqqLX5R1X345qqfHbsf67hvA3Nn add-link foo kitten
Error: Post http://127.0.0.1:5001/api/v0/object/patch/add-link?arg=QmUNLLsPACCz1vLxQVkXqqLX5R1X345qqfHbsf67hvA3Nn&arg=foo&arg=kitten&encoding=json&stream-channels=true: EOF

The firs response makes sense. I'm not sure the second does - an empty argument shouldn't be allowed, I don't think. The third hangs in the HTTP API, but returns this strange inscrutable error in the CLI.

Not sure what is going on here. Discovered as part of ipfs-inactive/http-api-spec#32.
@RichardLitt RichardLitt added the kind/support A question or request for support label Mar 20, 2016
@RichardLitt
Copy link
Member Author

Blocking ipfs-inactive/http-api-spec#68.

@whyrusleeping whyrusleeping mentioned this issue Apr 18, 2016
Closed
@whyrusleeping whyrusleeping added the help wanted Seeking public contribution on this issue label Aug 23, 2016
@whyrusleeping whyrusleeping removed their assignment Aug 23, 2016
@whyrusleeping whyrusleeping mentioned this issue Aug 23, 2016
Open
@lidel
Copy link
Member

lidel commented Mar 21, 2024 •
edited
Loading

Object API has been deprecated since 2021 (#7936), we won't be fixing bugs related to it.

Consider switching to modern ipfs dag or ipfs files APIs.

@lidel lidel closed this as not planned Won't fix, can't repro, duplicate, stale Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Seeking public contribution on this issue kind/support A question or request for support
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lidel @RichardLitt @whyrusleeping