Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DLP deprecation of "totalHeightWithExtrusion" #127

Closed
OllisGit opened this issue Feb 17, 2020 · 2 comments
Closed

DLP deprecation of "totalHeightWithExtrusion" #127

OllisGit opened this issue Feb 17, 2020 · 2 comments
Labels
enhancement New feature or request
Milestone
1.11.2

Comments

@OllisGit
Copy link
Contributor

Hi,

I saw in your implementation that you use "totalHeightWithExtrusion", because totalHeight was not available.
https://github.com/StefanCohen/OctoPrint-Dashboard/blob/master/octoprint_dashboard/static/js/dashboard.js#L26

Since Version 1.17.0 the "totalHeight"-attribute is now the correct way to read the height. The calculation is related to the "height mode" in Plugin-Settings.

Please change your plugin to the correct attribute, so that I can remove the other attribute.

Thx, in advance
Olli
@StefanCohen
Copy link
Collaborator

I finally have had time to set up a new dev env so this will be fixed in the next release.

@StefanCohen StefanCohen added the enhancement New feature or request label Mar 3, 2020
@StefanCohen StefanCohen added this to the 1.11.2 milestone Mar 3, 2020
@StefanCohen
Copy link
Collaborator

Fixed in 1.11.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.11.2
Development

No branches or pull requests
2 participants
@OllisGit @StefanCohen