Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.6.0 breaks M117 command! #53

Closed
ochm opened this issue Sep 29, 2019 · 2 comments
Closed

1.6.0 breaks M117 command! #53

ochm opened this issue Sep 29, 2019 · 2 comments
Labels
bug Something isn't working
Milestone
1.6.1

Comments

@ochm
Copy link

ochm commented Sep 29, 2019

When updated Dashboard to version 1.6.0, printer stopped display about Octopi Connected,disconnected.
After short investigation i foud that M117 is not sent, is not visible in serial monitor log.
Ony some like M117 x123 is vissible, but no M117 Hello world

To Reproduce
Try to send M117 Something and do verify what is displayed on printer.

Expected behavior
Display on printer what was sent by M117.

When the dashboard plugin is disabled od uninstalled, everything about M117 goes well.
@StefanCohen StefanCohen added the bug Something isn't working label Sep 29, 2019
@StefanCohen
Copy link
Collaborator

Thanks. I think I know what went wrong and will try to fix that.

@ochm ochm changed the title 1.0.6 breaks M117 command! 1.6.0 breaks M117 command! Sep 29, 2019
@StefanCohen StefanCohen mentioned this issue Sep 29, 2019
Closed
@StefanCohen StefanCohen added this to the 1.6.1 milestone Sep 29, 2019
@StefanCohen
Copy link
Collaborator

StefanCohen commented Sep 29, 2019 •
edited
Loading

Confirmed. It was a botched GCODE parser introduced in v1.6.0. Fixed in v1.6.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.6.1
Development

No branches or pull requests
2 participants
@StefanCohen @ochm