Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Photo click binding #719

Open
jcuenod opened this issue May 14, 2015 · 3 comments
Open

Photo click binding #719

jcuenod opened this issue May 14, 2015 · 3 comments

Comments

@jcuenod
Copy link

jcuenod commented May 14, 2015

Currently the click handler for the photo is bound inline: https://github.com/jackmoore/colorbox/blob/master/jquery.colorbox.js#L1016

If anyone wants to override that or remove it s/he needs to use removeAttr() rather than the more obvious off(). It also doesn't have the prefix (as most of the other bindings do).

I would actually also like to see that function turned into a default setting that can be modified. So:

photo.on("click", settings.get('clickHandler'));
@jackmoore
Copy link
Owner

That sounds like a good idea to me.

@jcuenod
Copy link
Author

jcuenod commented May 14, 2015

Do you want a pull request?

@jackmoore
Copy link
Owner

I didn't turn it into a setting yet because I might want to revise how that is handled.

@jackmoore jackmoore reopened this May 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants