Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS error when using initialWidth/initialHeight options on IE8 #741

Closed
jon301 opened this issue Jul 27, 2015 · 2 comments
Closed

JS error when using initialWidth/initialHeight options on IE8 #741

jon301 opened this issue Jul 27, 2015 · 2 comments

Comments

@jon301
Copy link

jon301 commented Jul 27, 2015

Hi,
I believe a regression has been introduced in release v1.5.6 : the plugin throws an error when using initialWidth or initialHeight options on IE8

Version 1.5.6 - 2014/4/4
Applied maxWidth and maxHeight to the initialWidth and initialHeight. Fixes #391

Here are some URL examples :
v1.5.5, working on IE8
http://output.jsbin.com/mawucu

v1.5.6, not working on IE8
http://output.jsbin.com/qerose

The bug is still here on the current version (v1.6.2)

Thank you for your help
@jackmoore
Copy link
Owner

I believe that should fix it. Thanks for doing so much of the leg work on this.

@jon301
Copy link
Author

jon301 commented Jul 27, 2015

It works, thanks for your very fast answer !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jackmoore @jon301