Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy-paste error in tagger implementation #34

Closed
ZhanruiLiang opened this issue Oct 4, 2022 · 1 comment
Closed

Copy-paste error in tagger implementation #34

ZhanruiLiang opened this issue Oct 4, 2022 · 1 comment
Labels

Comments

@ZhanruiLiang
Copy link

Describe the bug
Code location:
https://github.com/jacksonllee/pycantonese/blob/main/src/pycantonese/pos_tagging/tagger.py#L262
From the context, i+2 should be used but it has i-2 currently.
I tried to fix and and regen the model pickle file, but that fails some tests which I don't know how to proceed.

To reproduce

  • Change i-2 to i+2 in the linked line and the line below.
  • Regenerate model by running train_tagger.py
  • Run tests `python -m pytest tests/test_parsing.py

Expected behavior
All tests pass.

System (please complete the following information):

  • Operating System: MacOS
  • PyCantonese version: 3.4.0
@jacksonllee
Copy link
Owner

I've resolved this issue at the main branch. Some of the tests got upset due to noise in the training data from HKCanCor -- that's been fixed as well.

You've been acknowledged in the readme. Thank you for reporting this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants