Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javascript chunks that do not end in .js are excluded #1013

Closed
sechel opened this issue Jul 30, 2018 · 4 comments
Closed

Javascript chunks that do not end in .js are excluded #1013

sechel opened this issue Jul 30, 2018 · 4 comments

Comments

@sechel
Copy link

sechel commented Jul 30, 2018

Expected behaviour

Add javascript chunk files that do not end in .js.

Current behaviour

Chunk files that do not end in .js are excluded explicitly since v3.0.4, see 0348d6b.

Environment

This problem occurs when using html-webpack-plugin in conjunction with karma-webpack as they use the chunk name as file name (https://github.com/webpack-contrib/karma-webpack/blob/1ac16eaa7b11ee154a2127d4f03cbfd1a81533f6/src/karma-webpack.js#L65). Not sure though who should move you or them 😄.

@jantimon
Copy link
Owner

Oh thanks a lot 👍
Right now we are doing some heavy lifting to get to version 4 of the plugin: #953

Maybe the asset gathering will also pick up karma-webpack files.
However filtering for .js chunks doesn't sound wrong to me

@sechel
Copy link
Author

sechel commented Jul 31, 2018

Hey @jantimon, the best thing would be to analyze the contents of the asset (or maybe webpack does know anyways?). But actually you are right it sound more right to me that the karma-webpack folks should rename their test bundles to end with .js 😄 I will link from their place to here.

@sechel
Copy link
Author

sechel commented Jul 31, 2018

See also codymikol/karma-webpack#334

@jantimon jantimon closed this as completed Aug 8, 2018
@lock
Copy link

lock bot commented Sep 7, 2018

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants