Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function extend does not properly expose static properties from base classes #4217

Open
SylvainCorlay opened this issue Jun 30, 2019 · 3 comments

Comments

@SylvainCorlay
Copy link

If a backbone model is an ES6 class with a statc property, and one use Model.extend to make a subclass (instead of the ES6 extends), the static properties of the base model are not added to the subclass.

@blikblum
Copy link

This is one of the issues with ES6 classes. See #3560 for discussion.

@SylvainCorlay
Copy link
Author

@blikblum I have gone through this discussion earlier. I am not sure the specific issue that I am describing is covered in the discussion..

@oliverfoster
Copy link

@SylvainCorlay does my PR fix your issue? Static propery inheritance on the constructors?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants