Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash if included html that extends from other html #140

Open
LuisReyes98 opened this issue Jan 16, 2019 · 15 comments
Open

Crash if included html that extends from other html #140

LuisReyes98 opened this issue Jan 16, 2019 · 15 comments

Comments

@LuisReyes98
Copy link
Contributor

Issue

The theme loader will crash if it is included a component
{% include "component.html" %}
and that component is extending from something else
{% extends "component-2.html" %}

Recreating the error

trying to run the theme multi-component-example thats has as parents component-holder and component-sitter will cause the it to crash

@naturallymitchell
Copy link
Member

why doesn't multi-component-example inherit from base-theme?

@LuisReyes98
Copy link
Contributor Author

Because I wanted to have the least amount of themes to recreate the error

@Arnaz87
Copy link
Collaborator

Arnaz87 commented Jan 19, 2019

Does including usually works? The theme rewriter does not mind the content of the files so I don't think the issue is there. What's the error message of the crash?

@naturallymitchell
Copy link
Member

there's no message, I believe, since torchbear panics. see jazzdotdev/jazz#214 (comment)

@naturallymitchell
Copy link
Member

"The theme loader will crash"....?
meaning, the tera bindings.. that could go with what Keats told us in jazzdotdev/jazz#128

@Arnaz87
Copy link
Collaborator

Arnaz87 commented Jan 19, 2019

It would've be nice if you had made a lighttouch branch with the themes, so one can just clone it and run it

@Arnaz87
Copy link
Collaborator

Arnaz87 commented Jan 19, 2019

I can include the holder if that holder does not extends the parent

@Arnaz87
Copy link
Collaborator

Arnaz87 commented Jan 19, 2019

I can also {% include "^/component-holder.html" %} so it definitely is not a template rewriter error, this is a tera bug.

@naturallymitchell
Copy link
Member

@Arnaz87 @LuisReyes98 what exactly is the change we need to make now?

something like, "add support for X in Y"..

jazzdotdev/jazz#214 (comment)

@Arnaz87
Copy link
Collaborator

Arnaz87 commented Jan 25, 2019

Error report, using tera 1.0 alpha
https://pastebin.com/0KyN7kyw

@Arnaz87
Copy link
Collaborator

Arnaz87 commented Jan 25, 2019

@Arnaz87
Copy link
Collaborator

Arnaz87 commented Jan 25, 2019

This error is most likely a Tera error, we need a pure rust-tera example of it, so that either Keats or us can fix it.

@Arnaz87
Copy link
Collaborator

Arnaz87 commented Jan 25, 2019

@Arnaz87
Copy link
Collaborator

Arnaz87 commented Jan 26, 2019

Keats/tera#385

@naturallymitchell
Copy link
Member

fixed upstream in foundpatterns/tera master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants