Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: I'm having issues with videos rendering in chat #311

Closed
dillfrescott opened this issue Jun 7, 2024 · 6 comments
Closed

Bug: I'm having issues with videos rendering in chat #311

dillfrescott opened this issue Jun 7, 2024 · 6 comments

Comments

@dillfrescott
Copy link

Images work fine, but videos tend to either spin forever or the play is grayed out and either way the thumbnail or video doesnt show up, just the box with the play pause and stuff.

@jeremyckahn
Copy link
Owner

Thanks for reporting this @dillfrescott. I am able to reproduce with a relatively small Big Buck Bunny test video: https://download.blender.org/peach/bigbuckbunny_movies/BigBuckBunny_320x180.mp4.

This seems to be an issue somewhere upstream in the libraries that Chitchatter is using to implement video embeds (webtorrent/webtorrent#1887). I don't have time to properly diagnose and fix this issue, so I'm going to look to disable it for now.

@dillfrescott
Copy link
Author

Gotcha! Okay

@jeremyckahn
Copy link
Owner

This is addressed in 56dbbf2. With this change, inline media rendering will abort and print an error message if the file extension is unsupported. This is a quick fix and it's not as graceful as I'd like, but it should at least avoid users dealing with an obviously-broken experience.

Thanks for reporting this @dillfrescott!

@brentonv
Copy link

brentonv commented Jun 9, 2024

Wow videostream "only mp4 files are supported" and "mp4 files with certain audio codecs not playing" and last commit "Nov 12, 2020"

@dillfrescott
Copy link
Author

Oh damn. Yeah looks like a better solution is in order.

@jeremyckahn
Copy link
Owner

Yeah... some of the libraries that Chitchatter depends on are a little old and creaky. They generally work well enough, but there are some rough edges like this. I don't know of any modern, maintained alternatives. 😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants