You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The data to be displayed is in the QR code div, rather than separated in some (potentially static) JS file at worst, or at the bottom of my page at best.
It fails better if the client has JS disabled.
I see you've updated the API call to take an argument, I was going off the GitHub page. What I propose is, in addition to:
Width, height and text could be retrieved from the div (and width/height set in CSS), which is a cleaner separation and more in line with the spirit of HTML/CSS.
Why not optionally put the data in the div, like so?:
This would also fail gracefully and just display the data. The existing call for using the library would override this method.
The text was updated successfully, but these errors were encountered: