Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite in Swift + Support SwiftPM #18

Open
5 tasks
jessesquires opened this issue Jul 25, 2015 · 1 comment
Open
5 tasks

Rewrite in Swift + Support SwiftPM #18

jessesquires opened this issue Jul 25, 2015 · 1 comment
Assignees
Milestone

Comments

@jessesquires
Copy link
Owner

jessesquires commented Jul 25, 2015

Let's rewrite this library in Swift 3.0 🎉

This is a long term goal, and mostly for fun. Especially with nullability annotations, there is very little value to gain by doing this.

But, Swift is awesome™ and the future™, so it would be fun to rewrite this. Also, it's a pretty small framework so it shouldn't be too difficult or take too long.

⚠️ Waiting for the final release of Swift 3.0 to do this.

Todos:

  • Rewrite in Swift
  • Update docs
  • Update unit tests
  • Update travis-ci
  • Rewrite demo projects in Swift

Some notes:

  • Use an enum FileType for the file types (file extensions)
  • Use a struct for file names, which contains the name (String) and type (FileType)
  • Singletons in Swift

⚠️ NOTE: will not accept pull requests for this issue 😄


Any new features we can make use of in this library?

5.1

5.2

@jessesquires jessesquires self-assigned this Jul 25, 2015
@jessesquires jessesquires added this to the 5.0.0 milestone Jul 25, 2015
@s-faychatelard
Copy link

Hey!

I did a pre-rewrite of the library in Swift (1.2 for now)

https://github.com/s-faychatelard/JSQSystemSoundPlayer-Swift

It can be a good start for you maybe

EDIT: Added a branch for Swift 2.0 support, ported unit tests and added OS X support and example

@jessesquires jessesquires changed the title Rewrite in Swift 2.0 Rewrite in Swift Mar 7, 2016
@jessesquires jessesquires changed the title Rewrite in Swift Rewrite in Swift 3.0 Apr 8, 2016
@jessesquires jessesquires modified the milestones: 5.0.0, 6.0.0 Jan 1, 2018
@jessesquires jessesquires changed the title Rewrite in Swift 3.0 Rewrite in Swift Jan 8, 2018
@jessesquires jessesquires changed the title Rewrite in Swift Rewrite in Swift + Support SwiftPM Apr 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants