Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotations #12

Open
krakazyabra opened this issue Jan 10, 2023 · 2 comments
Open

Annotations #12

krakazyabra opened this issue Jan 10, 2023 · 2 comments

Comments

@krakazyabra
Copy link

Hi guys! Thanks for the project.

Can I ask you to add possibility to manage annotations/labels for components (svc, deploys, daemonsets)? F.e. they are needed for prometheus SD.

Thanks in advance ;-)
@hrenard
Copy link
Member

hrenard commented Jan 16, 2023

Hey !
Indeed, it's only possible for the ingress. I don't have a lot of time, but I can review a PR.
The idea for Prometheus was to only have to set .spec.metrics to true.

@krakazyabra
Copy link
Author

Hi!

I can review a PR

Sorry, but my go expirience is around 0 :) May be I can try to copy current code from ingress part and add it to ds/deployment etc. Or someone else will be kind to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hrenard @krakazyabra