Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin removes custom system commands #62

Closed
viljamip opened this issue Sep 27, 2018 · 5 comments
Closed

Plugin removes custom system commands #62

viljamip opened this issue Sep 27, 2018 · 5 comments

Comments

@viljamip
Copy link

I added custom System commands that use the hs100.sh script to turn the printer on and off. (I those can be used remotely with the Telegram plugin.)

If I use this plugin's on/off button (bolt-icon) from the Octoprint UI all of my custom System Commands are deleted for some reason.

Here is maybe a related issue where many users have mentioned that they use the HS100:
Salandora/OctoPrint-SystemCommandEditor#5

@jneilliii
Copy link
Owner

Do you have the system command editor plugin installed? Can you document how your system commands are configured so I can test on my end to see if I can reproduce. My plugin doesn't do anything related to system commands so not sure how it would be effecting it.

@viljamip
Copy link
Author

viljamip commented Sep 27, 2018

Yes I used the system command editor plugin. Here are my system commands copied from config.yaml:

system:
  actions:
  - action: 'on'
    command: /home/pi/Viljami/./hs100.sh -i 192.168.1.110 on
    name: 'On'
  - action: 'off'
    command: /home/pi/Viljami/./hs100.sh -i 192.168.1.110 off
    confirm: Power off?
    name: 'Off'
  - action: divider
  - action: focus
    command: v4l2-ctl -c focus_auto=0; v4l2-ctl -c focus_absolute=55
    name: Manual focus

I'm not completely sure that it is infact your plugin that is causing this but my system commands disappeared right after I had turned the printer on and off with your plugin's button. They were deleted multiple times so I feel that this issue is repeatable at least on my Octoprint. For now I disabled your plugin and I use only my system commands and it seems to be working.

@jneilliii
Copy link
Owner

I'd be curious if the system command editor could be disabled after setting your commands up. I think it writes directly back to config.yaml what it needs and there is no need to have it loaded unless you need to change your settings.

@viljamip
Copy link
Author

I disabled system command editor from the plugin manager and indeed I can't reproduce the issue anymore. I'll report back to you if my commands still get deleted but I think your guess was right. Thanks.

@jneilliii
Copy link
Owner

Great, feel free to reply back here if it comes back. Closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants