-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance Issue with small alphabets and long texts #4
Comments
I'll check this out and give you feedback in the next couple of days. |
I tried your tests and -- apart from the performance -- the tests worked. I think the problem here is that you chose to essentially benchmark your computer and some libraries using very pathological input. That's not a problem of StringSearch so closing this issue. |
No need to be rude:
I do not get a result after minutes. I am certain that you were mistaken and did not remove the @Ignore-Marker from the class before starting the test (as explained by me). After some debugging I found out, that the problem is not caused by an infinite loop, but as you said, from poor performance (maybe because of a wrong api usage). And it is just not a problem of the boyer moore horspool algorithm (the one of byteseek, java.util.Matcher and StringsAndChars perform slower than naive search, but faster than 5 seconds on the same scenario). One reason might be that your |
I tried to benchmark your library with StringBench.
Yet there seems to be a performance issue with some your implementations (BoyerMoore*, BNDM) related to a binary alphabet with long texts.
You can reproduce this by
Yet I cannot provide any hints to the problem - may be the test setup is incorrect. If so it would be kind helping me to fix it.
The text was updated successfully, but these errors were encountered: