Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Horizontal view, color, scales #98

Closed
Aphexus opened this issue May 3, 2019 · 2 comments
Closed

Horizontal view, color, scales #98

Aphexus opened this issue May 3, 2019 · 2 comments

Comments

@Aphexus
Copy link

Aphexus commented May 3, 2019

Hi, just found your software. Looks like! I have some suggestions.

  1. Allow a horizontal view for the scales and chords(I only see vert)

  2. Add piano(it's just a single string like scale where the frets are the notes so you might be able to just change the view of the chords and scales visually without having to modify the internals. (it's just a view thing, the internal model doesn't really need to change if it's too complex to do so)

  3. Add violin, cello, viola, etc... all the same as chords, just different tuning, # of strings, etc).

  4. Scale is only returning one note per string, should show all the notes across the fretboard with limitations to box patterns.(possibly allow limiting to box with notes outside the box semi-transparent) [this seems to be a bug but not all notes are being shown]

  5. Use colors. It's also important to know the degree's/function of the notes in a scale C major and A minor are not the same scales enough though they have the same notes. Using color which maps scale degree to a color would be useful.

  6. Instead of letters allow to show degree's too. R = root, Chord qualities with repeating notes don't work #9, b9, Diagram export overwriite overwrites files as they're made #11, etc. This is more important than knowing the letter names.

  7. Allow for a true scale and chord finder by selecting notes on the fretboard and it showing all the scales that fit, sorta like: http://www.all-guitar-chords.com/reverse_scales.php

But even if one adds a single note it should show all the scales that the note belongs too. e.g., adding B-F will give C major, C Harmonic minor, and Gb Major, Gb harmonic minor, etc... and it would be nice if it did it in "real time". Your finding algorithm seems to be slow but it could be done in a thread and it's results updating the list of found items in parallel.

Thanks.

@jonthysell
Copy link
Owner

Thank you for your feedback.

Most of what you're asking can be done manually by editing the diagrams. If it's a default style you want to apply to all of your diagrams, you can change it in the user style editor.

  1. You can change the orientation in the diagram/style editor.

chordious C pizygwmk

  1. Chordious is specifically designed for drawing fretboard diagrams, not tabs or sheet music. I currently have no plans to support anything but fretboard diagrams.
  2. Chordious already supports adding custom instruments and tunings.
  3. The scale finder works as designed, it shows every combination of a complete scale pattern. However having all the notes in a box is an interesting option, opened Scale Finder: Add option to show a "box pattern" #99 to track it.
  4. You can change the colors of marks or their text in the diagram/style editor.

chordious C gqyqok1g

Having the finders automatically assign colors is an interesting idea, though I'd really have to think through how best to enable it.

  1. You can change the text in the diagram editor. Having the Finders do this automatically is being tracked by Finders: Allow note text to be Note/Interval name #60.

  2. Adding a "reverse" finder is being tracked by Add a "Reverse" Chord Finder #91.

@Aphexus
Copy link
Author

Aphexus commented May 7, 2019

  1. No, I simply mean drawing a piano keyboard and displaying the keys as highlighted. Not tab or sheet music. E.g., https://www.pianochord.org/

The main purpose here is to allow visualizing chords for piano. I believe all you really have to do is modify the visual output to display a piano keyboard so very little work has to be done. That is, a piano still is treated as a fretted instrument but just looks different visually.

  1. The colors should be by degree or function. E.g., the root will be blue, the 5th red, the Chord qualities with repeating notes don't work #9 purple.
    This allows one to quickly see the function of the notes in the chords rather than just black dots, which tells one nothing of how the note behaves in the chord.

Thanks, I will check out the other stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants