Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance for medium to big elections #8

Open
jontingvold opened this issue Oct 7, 2020 · 3 comments
Open

Improve performance for medium to big elections #8

jontingvold opened this issue Oct 7, 2020 · 3 comments
Labels
enhancement-on-todolist New feature or request Important

Comments

@jontingvold
Copy link
Owner

No description provided.

@jontingvold jontingvold created this issue from a note in Sprint 2 (Someday maybe) Oct 7, 2020
@jontingvold jontingvold added the enhancement-on-todolist New feature or request label Oct 7, 2020
@matthewdeanmartin
Copy link

I can report that the code is noticeably slow with 100s of candidates. I just reduced the number of candidates & ran at an acceptable speed again.

@jontingvold
Copy link
Owner Author

jontingvold commented Jan 25, 2021 •
edited
Loading

Thanks. Good to know. Then I will definitely try to optimize it with Numpy/Pandas some time.

@jontingvold jontingvold changed the title Check performance for very big elections Improve performance for very medium/big elections Jan 25, 2021
@jontingvold jontingvold changed the title Improve performance for very medium/big elections Improve performance for medium/big elections Jan 25, 2021
@jontingvold jontingvold changed the title Improve performance for medium/big elections Improve performance for medium to big elections Jan 25, 2021
@matthewdeanmartin
Copy link

matthewdeanmartin commented Jan 25, 2021 •
edited
Loading

Counterpoint though, it is kind of nice to have a pure python library. What sort of workloads were you expecting? For my algo, my intuition was that having 2 voters with votes for 500 candidates & the rest with votes for 1 or 2 candidates was just a bad idea, (the 500th candidate on a ballot isn't going to win anyhow) & performance was better truncating the 2 voters' ballots with too many candidates on their ballots. Here is my code if you're curious: https://github.com/matthewdeanmartin/whats_that_code/blob/main/whats_that_code/election.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement-on-todolist New feature or request Important
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jontingvold @matthewdeanmartin