Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix responses to be more standards compliant #145

Merged
merged 4 commits into from
Feb 3, 2019
Merged

Fix responses to be more standards compliant #145

merged 4 commits into from
Feb 3, 2019

Conversation

joohoi
Copy link
Owner

@joohoi joohoi commented Feb 3, 2019

This PR adds correct handling for:

  • EDNS requests, by indicating that EDNS isn't implemented: FORMERRsome
  • Figure out if some of the parent domains exists in case of NXDOMAIN and set authoritative bit and append SOA record for caching.
  • If other than requested records exist for domain, return an empty NOERROR response.

Fixes #127

@joohoi joohoi merged commit de7fe3c into master Feb 3, 2019
@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 93.704% when pulling bbce3a6 on dnsfixes into 7a2f9f0 on master.

@joohoi joohoi deleted the dnsfixes branch February 3, 2019 22:05
jacobmyers-codeninja pushed a commit to jacobmyers-codeninja/acme-dns that referenced this pull request Sep 30, 2020
@joohoi
Fix responses to be more standards compliant (joohoi#145)
a9d40f5 
* Handle OPT questions (EDNS)

* Handle authoritative bit, and append SOA for authoritative NXDOMAIN responses

* Changelog entry

* Fix linter errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joohoi @coveralls