added custom ca provider #283
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mschneider82
commented
Oct 12, 2021
•
mschneider82
commented
t0xicCode
reviewed
Dec 31, 2021
| @@ -1,4 +1,5 @@ | |||
| //+build !test | |||
| //go:build !test | |||
There was a problem hiding this comment.
This syntax is for go1.17 and later.
Given that acme-dns still claims to compile with go1.13, the original syntax should be maintained.
There was a problem hiding this comment.
this was done automaticlly by the IDE/go tools, i think the compatiblity should be ok since line 2 has the old syntax. I think its good to have both syntax supported since the old one may gets removed one day.
linuxgemini
added a commit
to linuxgemini/acme-dns
that referenced
this pull request
Feb 9, 2022
Co-authored-by: Matthias Schneider <[email protected]> Signed-off-by: İlteriş Yağıztegin Eroğlu <[email protected]>
linuxgemini
added a commit
to linuxgemini/acme-dns
that referenced
this pull request
Feb 9, 2022
Co-authored-by: Matthias Schneider <[email protected]> Co-authored-by: Johannes Doll <[email protected]> Signed-off-by: İlteriş Yağıztegin Eroğlu <[email protected]>
t0xicCode
added a commit
to MagnaXSoftware/acme-dns
that referenced
this pull request
Jun 16, 2022
This was referenced Jun 16, 2022
t0xicCode
added a commit
to MagnaXSoftware/acme-dns
that referenced
this pull request
Jul 24, 2023
t0xicCode
added a commit
to MagnaXSoftware/acme-dns
that referenced
this pull request
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.