Refactoring #325
Open
Refactoring #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repository owner
deleted a comment from
coveralls
Dec 25, 2022
* chore: enable more linters and fix linter issues * ci: enable linter checks on all branches and disable recurring checks recurring linter checks don't make that much sense. The code & linter checks should not change on their own over night ;) * chore: update packages * Revert "chore: update packages" This reverts commit 30250bf. * chore: manually upgrade some packages
|
How can we help you get this merged? Are there specific areas that need/could use review? Or is it simply an question of time? (totally valid, no worries) |
|
@hellerbarde I'm on it now! Thanks for the bump, it's been mainly a time issue as I have multiple projects on my hands and as the refactoring wasn't super high on the priority list, it just simply got forgotten. It's important to get in however, as not merging it is effectively blocking fixes and features in order to not to create a jungle of merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Huge refactoring PR to get acme-dns to a more maintainable state. Some new improvements done at the same time.