Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable click event after clicked to link #21

Closed
pavelthq opened this issue Sep 24, 2014 · 7 comments
Closed

disable click event after clicked to link #21

pavelthq opened this issue Sep 24, 2014 · 7 comments

Comments

@pavelthq
Copy link
Collaborator

to prevent nested manipulations with link ( like opening in open tab )
it will be great if you added in function setupEvents

$this.click(function (e) {
                    e.preventDefault();

preventDefault solves some problem for me.. and I think it is good to avoid href="javascript:void();"

or you can make it optionally something like

$this.click(function (e) {
                    base.options.preventEvent && e.preventDefault();

and make base.options.preventEvent = true

@eugenesimakin
Copy link
Collaborator

Привет, я согласен с первой частью, но делать preventDefault() опцией мне кажется лишним.

PS If you can't understand, let me know.

@pavelthq
Copy link
Collaborator Author

Да можно и на русском, я для удобства других людей пишу на англ.

Тоже считаю что опция лишнее.

@eugenesimakin
Copy link
Collaborator

@eugenesimakin
Copy link
Collaborator

Cause for issue #25

@eugenesimakin
Copy link
Collaborator

Release 1.2.4

@vatnoise
Copy link

А оно точно работает? Я когда кликаю на кнопки, меня бросает наверх страницы. Версия v1.3.1

@pavelthq
Copy link
Collaborator Author

как бы должен, можете сделать codepen/jsfiddle?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants