Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ghc::filesystem install its headers and cmake files into system #825

Closed
guoyunhe opened this issue Nov 4, 2019 · 4 comments
Closed

ghc::filesystem install its headers and cmake files into system #825

guoyunhe opened this issue Nov 4, 2019 · 4 comments

Comments

@guoyunhe
Copy link
Contributor

guoyunhe commented Nov 4, 2019

After running make install, I see it installed some hpp and cmake file installed in /usr/include/ghc and /usr/lib64/cmake. They are not needed by Play! and should not be installed.
@Zer0xFF
Copy link
Contributor

Zer0xFF commented Nov 6, 2019

Play! doesn't do anything special in terms of specifying those files for install.
so it's its probably best to redirect this issue to https://github.com/gulrak/filesystem/ perhaps an option to enable/disable install, so we can set option on our end.

what are the cmake related stuff currently being installed?

@guoyunhe guoyunhe mentioned this issue Nov 6, 2019
Closed
@guoyunhe
Copy link
Contributor Author

Good news. With new release of ghc::filesystem, you can set GHC_FILESYSTEM_WITH_INSTALL=OFF to disable the installation of these files.

@Zer0xFF
Copy link
Contributor

Zer0xFF commented Dec 3, 2019

can be closed

@guoyunhe
Copy link
Contributor Author

guoyunhe commented Dec 7, 2019

Yes, it has been fixed.

@guoyunhe guoyunhe closed this as completed Dec 7, 2019
@SoilRos SoilRos mentioned this issue Feb 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Zer0xFF @guoyunhe