-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copper Plane Tearing #26
Comments
This issue is related to rounding errors and how the Gerber is defined. Instead of following Gerber best practices (i.e. draw a solid copper pour and then cut holes into it with a negative layer), your CAD tool does a manual draw. I made a minimal example to show the problem (I've added white-space for readability, with comments at the end of each line):
This renders as follows in ViewMate: Now -- the generated PDF (I added white-space for readability and converted the mm back to inches in the comments):
The rounding error is especially evident on line 4. Instead of the correct coordinate (0.799973, 26.39822), the Bézier is drawn to (0.799962159, 26.39824483). You'll also notice that some of the Bézier curves end in completely the wrong place -- I'll investigate that first before fixing the rounding errors. Converting inches to mm should be exact, so there shouldn't be rounding errors (as is evident in the "line to" command on line 5). This renders as follows in Acrobat Reader: |
I found the cause... In the Gerber, the line The arc is 90 deg counter-clockwise, so if you add the center offset to X and Y, you "should" end up at (0.043305, 0.881890). That 0.000001 error is enough to cause confusion in my converter. I'll make it more robust to Gerber errors and push an update. |
all work now! thanks! |
Pleasure :-) |
Originally reported in #23 by @JonThe640
The copper plane seems to tear in the PDF output:
The text was updated successfully, but these errors were encountered: