New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize the logic for handling moundpod. #881

Open

zxh326 opened this issue Feb 28, 2024 · 0 comments

Labels

Member

zxh326 commented Feb 28, 2024

Now we have two methods to manage the creation of mountpod.

juicefs-csi-driver/pkg/juicefs/mount/pod_mount.go

Line 314 in a28c9b3

func (p *PodMount) createOrAddRef(ctx context.Context, podName string, jfsSetting *jfsConfig.JfsSetting, appinfo *jfsConfig.AppInfo) (err error) {
juicefs-csi-driver/pkg/controller/pod_driver.go

Line 342 in a28c9b3

for {

There is a lot of duplicate code, and many inconsistencies in logic. It's best to have a unified way to manage it.

zxh326 added the kind/feature label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment