Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soil file is not written correctly #32

Open
aarojas20 opened this issue Jun 15, 2022 · 0 comments
Open

Soil file is not written correctly #32

aarojas20 opened this issue Jun 15, 2022 · 0 comments

Comments

@aarojas20
Copy link
Contributor

aarojas20 commented Jun 15, 2022

Describe the bug
Similar to the issue with file X, #31, the soil file is not written correctly, and therefore cannot be read in by DSSAT.

To Reproduce
Steps to reproduce the behavior:

  1. Minimalistic example (the shortest complete code that causes the mistake)
sol = soil_file.SoilFile("../data/maize_ghwa/soil.SOL") 
sol.write("../data/maize_ghwa_tradssat_soil/soil_tradssat_v_0_1_5.SOL")
  1. Version of traDSSAT (tradssat.__version__) and operating system (Linux, Windows, Mac, ...)
  • traDSSAT version is 0.1.5
  • My OS is MacOS Catalina Version 10.15.7
  1. A copy of any DSSAT input file(s) involved

Expected behavior
The formatting of the soil profiles within the newly written .SOL file do not match the ones that are provided by DSSAT. The formatting is off. (I have provided a few screen shots to illustrate this where the left one shows the correct .SOL and the file on the right shows the one that is re-written with tradssat.) As a result, the DSSAT software cannot read the newly written file correctly, and a simulation is terminated.
Screen Shot 2022-06-15 at 1 05 50 PM

Additional context
Add any other context about the problem here.

  • I think the underlying issue is related to the alignment of the variable with the numerical values. For example, SLB ends on the 6th column, but the number underneath is ends on the 7th column. SLB should also end on the 7th column.

I'll start a PR on this, and would be grateful for any additional guidelines here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant