Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] - Add a jupyter/minimal-notebook:python-3.10.x image #1688

Closed
Croydon opened this issue Apr 25, 2022 · 7 comments · Fixed by #1711
Closed

[ENH] - Add a jupyter/minimal-notebook:python-3.10.x image #1688

Croydon opened this issue Apr 25, 2022 · 7 comments · Fixed by #1711
Labels
type:Enhancement A proposed enhancement to the docker images

Comments

@Croydon
Copy link

Croydon commented Apr 25, 2022

What docker image(s) is this feature applicable to?

minimal-notebook

What changes are you proposing?

I would like to see a jupyter/minimal-notebook:python-3.10.x image.

How does this affect the user?

They can use a newer Python version

Anything else?

No response

@Croydon Croydon added the type:Enhancement A proposed enhancement to the docker images label Apr 25, 2022
@Croydon
Copy link
Author

Croydon commented Apr 25, 2022

Generally asked: Where are Python versions declared in this repository?

The jupyter/minimal-notebook:python-3.9.x images are missing the latest patch versions too

@mathbunnyru
Copy link
Member

Hi, @Croydon!

This is where python comes from:
https://github.com/jupyter/docker-stacks/blob/master/base-notebook/Dockerfile#L100

We install latest Miniforge3 and currently it comes with python 3.9.
https://github.com/conda-forge/miniforge#miniforge3

As soon as this project decides that python3.10 should be used by default, we will automatically start using python 3.10.

@maresb
Copy link
Contributor

maresb commented May 1, 2022

We have just removed Miniforge3 thanks to Micromamba, so unless something unexpected goes wrong in the coming days, we should be able to set the Python version ourselves now.

@mathbunnyru
Copy link
Member

The jupyter/minimal-notebook:python-3.9.x images are missing the latest patch versions too

This one is fixed automatically by using micromamba.

@bjornjorgensen
Copy link
Contributor

ARG PYTHON_VERSION=3.9
its it python 3.9 but why can't we use 3.10?

@maresb maresb mentioned this issue May 26, 2022
4 tasks
@maresb
Copy link
Contributor

maresb commented May 26, 2022

@bjornjorgensen I didn't change it earlier, based solely on the principle of changing only one thing at a time (transitioning from Mambaforge to Micromamba). As far as I know there are no blockers here, and Python 3.10 has been out for a long time now, so let's see what happens with #1711. Thanks for the push.

@Croydon
Copy link
Author

Croydon commented May 30, 2022

Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:Enhancement A proposed enhancement to the docker images
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants