Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(events): update the ApiEventsType for PaymentsSessionResponse to use payments flow #5059

Closed
lsampras opened this issue Jun 20, 2024 · 3 comments · Fixed by #5126
Closed
Assignees
Labels
A-Analytics C-bug Category: Bug good first issue Good for newcomers

Comments

@lsampras
Copy link
Member

update the ApiEventMetric trait for this response to return ApiEventsType::Payment { payment_id : String} variant.
based on the payment id stored in its body

This would help for better structuring and help list this api call in the dashboard events as well

@lsampras lsampras added C-bug Category: Bug good first issue Good for newcomers A-Analytics labels Jun 20, 2024
@tanbirali
Copy link
Contributor

I am interested

@aayushdhiman01
Copy link

I would like to work on this issue.

@lsampras lsampras assigned tsdk02 and unassigned tsdk02 Jun 24, 2024
@lsampras
Copy link
Member Author

lsampras commented Jun 24, 2024

Assigning this issue to @tanbirali since he asked first.
@aayushdhiman01 you can take a look at similar open issues. (maybe take a look at #4525 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Analytics C-bug Category: Bug good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants