Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use +platform dirs and conditional compilation properly #108

Open
kaavyajayram opened this issue Jan 18, 2020 · 2 comments
Open

use +platform dirs and conditional compilation properly #108

kaavyajayram opened this issue Jan 18, 2020 · 2 comments
Assignees
@mobile-bungalow @kaavyajayram

Comments

@kaavyajayram
Copy link
Collaborator

kaavyajayram commented Jan 18, 2020 •
edited
Loading

for mobile (and desktop because inline runtime target checking is bad)
@kaavyajayram kaavyajayram changed the title use + platform dirs and conditional compilation properly use +platform dirs and conditional compilation properly Jan 18, 2020
@mobile-bungalow
Copy link
Collaborator

I have done this on windows_notifications, the tray icon should be a dummy object on every platform except for windows.

@mobile-bungalow
Copy link
Collaborator

the question is weather or not we should move the file dialog routing for IOS out into a platform dir. I think we should wait, it seems like we will have to wrap Android as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mobile-bungalow mobile-bungalow

@kaavyajayram kaavyajayram

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mobile-bungalow @kaavyajayram