Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support asset "groups" (header/footer) #57

Open
GermontZ opened this issue Jan 2, 2016 · 8 comments
Open

Support asset "groups" (header/footer) #57

GermontZ opened this issue Jan 2, 2016 · 8 comments

Comments

@GermontZ
Copy link

GermontZ commented Jan 2, 2016

Hello!
I am using this plugin from time to time, and I really enjoy its simplicity, and that's why I came back one more time to it, installing the beta version (0.3).

For me it works just fine. I have a particular issue with two .js files that MUST use wp_head (is this correct? or 'load in header').
jquery.smartmenus.min.js
jquery.js
I applied the filter as you provided an example on your site, but this is not perfect yet.
Minit plugin will have a limited use considering the http2 implementation. Why shouldn't it be the most complete and effective for users which still use the usual http protocol.
My point is it would be very cool to join also script files loaded at top. I don't know a bit about coding, but maybe @kasparsd could find an easy solution for it.

Thanks!

@szepeviktor
Copy link
Contributor

@GermontZ
Copy link
Author

GermontZ commented Jan 2, 2016

I already solved that wiith examples from his blog and and stackoverflow, where already helped me on this issue. Thanks for the link though!

@szepeviktor
Copy link
Contributor

Please close this issue if it's solved.

@GermontZ
Copy link
Author

GermontZ commented Jan 3, 2016

I am sorry if I wasn't clear enough. Excluding files from footer concatenation is one thing. But creating a header bundle with them is a different story.

@kasparsd
Copy link
Owner

kasparsd commented Jan 3, 2016

@GermontZ It appears that many people have requested this feature so I'm thinking of adding it back in 0.3 but making it disabled by default (mainly because most people shouldn't need it) and having a filter for enabling it.

@kasparsd kasparsd changed the title Concatenation of 'wp-head' files Support asset "groups" (header/footer) Jan 3, 2016
@GermontZ
Copy link
Author

GermontZ commented Jan 3, 2016

This would make my day!
I write here one more idea. It would be neat to have this plugin published on WordPress.org respository. It makes an ideal pair with BJLazyLoad, at least for users that don't use Cloudflare RocketLoader + their lazy load options.
I can't afford donating, but I am curious about your last theme. I just hope will have it this year, I am foccussed on performance. All the best!

@kasparsd
Copy link
Owner

kasparsd commented Jan 3, 2016

Thanks for the suggestion, @GermontZ! The Minit plugin works only with themes and plugins that adhere to WordPress coding standards and unfortunately they are still a minority. It would cause a lot of support requests for which I don't have any time.

@GermontZ GermontZ closed this as completed Jan 3, 2016
@kasparsd
Copy link
Owner

kasparsd commented Jan 3, 2016

I'll leave the issue open until it's resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants