Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] KCLVM CLI clap deps is too low and need to upgrade the clap version. #333

Closed
Peefy opened this issue Dec 12, 2022 · 2 comments · Fixed by #560
Closed

[Enhancement] KCLVM CLI clap deps is too low and need to upgrade the clap version. #333

Peefy opened this issue Dec 12, 2022 · 2 comments · Fixed by #560
Assignees
@niconical
Labels
CLI good first issue Good for newcomers help wanted Extra attention is needed refactor

Comments

@Peefy
Copy link
Contributor

Peefy commented Dec 12, 2022 •
edited
Loading

Enhancement

KCLVM CLI clap deps is too low, upgrade the version and Refactoring code in the way recommended by clap. Ref: clap-rs/clap#2835
@Peefy Peefy added help wanted Extra attention is needed CLI labels Dec 12, 2022
@Peefy Peefy added this to the v0.4.5 Release milestone Dec 12, 2022
@Peefy Peefy added the good first issue Good for newcomers label Jan 9, 2023
@Peefy Peefy added the refactor label Jan 29, 2023
@Peefy Peefy modified the milestones: v0.4.5 Release, v0.4.6 Release Jan 29, 2023
@Peefy Peefy removed this from the v0.4.6 Release milestone Apr 10, 2023
@niconical
Copy link
Contributor

niconical commented May 19, 2023 •
edited
Loading

It seems to be a good introductory task about the clap library, and I hope to fix it soon.

@Peefy
Copy link
Contributor Author

Peefy commented May 19, 2023

It seems to be a good introductory task about the clap library, and I hope to fix it soon.

Thank you! I could assign this issue to U!

This was referenced May 28, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niconical niconical

Labels
CLI good first issue Good for newcomers help wanted Extra attention is needed refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: Upgrade kclvm/cmd clap version to 4.x
2 participants
@Peefy @niconical