-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: to_rpc_contract_class
is still returning contracts with a lot of missing data
#1316
Comments
Hi, would be interested to work on this. |
Thanks a lot @Juul-Mc-Goa ! Message me if you don't know how to design things. |
Hey @Juul-Mc-Goa, this one had been assigned to you but I don't think you ever worked on it. |
Hey, sorry got busy with other things. |
Starting next Monday will be great! Thank you |
make sure to read #790 as it is part of what you will be doing |
@Juul-Mc-Goa indeed it is not gossiped. We have to find some other way. Put your work here in hold, and open a discussion so that we can find the best way to do that. |
I'm working on this whole flow. There is a number of task to do first, but I'm on it |
There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale. |
We now have contract classes stored in the client (since #1409). wanna give it a try @Juul-Mc-Goa ? |
There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale. |
has this been fixed? @tdelabro @Juul-Mc-Goa |
@elielnfinic nope, still an issue |
I will come back to this after completing the other task you just assigned to me. If you don't mind, you can assign this to me too. |
Has this function been changed to |
@elielnfinic yes indeed |
Is conversion from |
I think, I am able to fix that conversion. |
@elielnfinic I think this PR will be fixed by some work I'm doing, storing the casm contract class on the client. |
I can create a draft PR to see if some parts of my code be used. |
Sure, but don't spend too much time on that :) |
Hey @tdelabro, please proceed, I will not submit the PR draft. |
There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale. |
Hey, Is this issue still relevant ? I would be interested to work on this. |
I'm on it #1631 |
This piece of code is still missing most fields. How to solve this?
Possible solution:
get_class
rpc requestThe text was updated successfully, but these errors were encountered: