Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(rpc-tests): Fail on running tests subsequently #1380

Open
antiyro opened this issue Jan 17, 2024 · 11 comments
Open

bug(rpc-tests): Fail on running tests subsequently #1380

antiyro opened this issue Jan 17, 2024 · 11 comments
Labels
backlog Ready to be picked bug Something isn't working

Comments

@antiyro
Copy link
Contributor

antiyro commented Jan 17, 2024

Bug Report

Currently the only way to pass all starknet-rpc-tests is to run the tests all togethers. Before then it was possible to run tests individually without depending on the others, this is possibly due to bad account balances manipulations.

Please comment under here if you observe reasons for individual tests to fail.

@antiyro antiyro added the bug Something isn't working label Jan 17, 2024
@tdelabro tdelabro added the backlog Ready to be picked label Jan 19, 2024
@tdelabro
Copy link
Collaborator

I believe in the past it wasn't always that way.

@azurwastaken
Copy link
Contributor

Would like to give it a look @EvolveArt

Copy link

github-actions bot commented Mar 8, 2024

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍
Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale label Mar 8, 2024
@tdelabro
Copy link
Collaborator

tdelabro commented Mar 8, 2024

@azurwastaken are you still working on this?

@azurwastaken
Copy link
Contributor

@azurwastaken are you still working on this?

Yes, have been really busy recently so I couldn’t make much progress.

I saw that most of test can be run individually as long as you restart madara between each launch so its probably caused by a to low balance as @antiyro said in the first message.

For the other ones who dont work even when we restart madara, i guess that they relate on other test to setup their initial state so i need to find out those relationship.

@tdelabro
Copy link
Collaborator

tdelabro commented Mar 8, 2024

@azurwastaken okay cool, keep up the good work!

@github-actions github-actions bot removed the stale label Mar 9, 2024
Copy link

github-actions bot commented Apr 8, 2024

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍
Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale label Apr 8, 2024
@tdelabro
Copy link
Collaborator

@azurwastaken what is the situation here?

@github-actions github-actions bot removed the stale label Apr 27, 2024
@azurwastaken
Copy link
Contributor

@azurwastaken what is the situation here?

Currently on holiday and had no time to work on it, if urgent i can leave this one to someone else, otherwise i’ll work on it when im back 🫡

Copy link

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a 👍
Because this issue is marked as stale, it will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale label May 29, 2024
@tdelabro
Copy link
Collaborator

@azurwastaken still on it?

@github-actions github-actions bot removed the stale label May 30, 2024
@azurwastaken azurwastaken removed their assignment Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Ready to be picked bug Something isn't working
Projects
Status: 🏗 In progress
Development

No branches or pull requests

3 participants